Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 10669038: base: Remove dereference structure operator (i.e ->) from ScopedVector. (Closed)

Created:
8 years, 6 months ago by tfarina
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

base: Remove dereference structure operator (i.e ->) from ScopedVector. BUG=128663 R=brettw@chromium.org,willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145073

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -101 lines) Patch
M base/memory/scoped_vector.h View 1 2 3 4 5 4 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_webapps_registry.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_parser.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_parser_unittest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/importer_list.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_backend.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 2 3 4 5 6 7 15 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/location_arbitrator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_resolver_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/host_resolver_impl_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/dns_transaction.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/mock_connection_manager.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +5 lines, -5 lines 0 comments Download
M ui/base/models/list_model.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/models/tree_node_model.h View 1 2 3 chunks +11 lines, -12 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Hi Will, could you review this to me?
8 years, 6 months ago (2012-06-27 00:40:11 UTC) #1
willchan no longer on Chromium
Still at Velocity for one more day. I think Brett ok'd this on the bug, ...
8 years, 6 months ago (2012-06-27 04:36:14 UTC) #2
brettw
8 years, 5 months ago (2012-06-28 19:13:13 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698