Close ArchivedDatabase connection after transaction rollback.

Close ArchivedDatabase connection after transaction rollback.

ArchivedDatabase::Init attempts to initialize its database tables
inside of a transaction. If the initialization fails, the transaction
object's destructor attempts to perform a rollback which fails because
the database connection has been closed.

Ensure that the transaction object is always destructed before
database closure by moving the table initialization into a separate
method.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145124

[brettw, 2012-06-27 17:12:22]

Just to clarify, this doesn't actually fix any bug right? Maybe the description
can be more clear that this is just a cleanup.

https://chromiumcodereview.appspot.com/10669033/diff/1/chrome/browser/history...
File chrome/browser/history/archived_database.cc (right):

https://chromiumcodereview.appspot.com/10669033/diff/1/chrome/browser/history...
chrome/browser/history/archived_database.cc:53: bool
ArchivedDatabase::DoInitTransaction() {
This name confused me because I read it as initializing a transaction rather
than initializing in a transaction. Maybe InitTables()?

[John Knottenbelt, 2012-06-28 07:45:28]

I was seeing a DCHECK failure in Chrome on Android running the html5tests suite
downstream ( http://b/issue?id=6735074 ) where it failed to init the
ArchivedDatabase. It hit a DCHECK while attempting to run an invalid rollback
statement in Connection::DoRollback. The statement was invalid because the
connection was already closed.

I'm not sure as to the underlying reason for the failure - perhaps a corrupt
database file? The problem has disappeared for us, and I'v not seen it on
desktop Chrome, so I think we could view this change as a cleanup?

[brettw, 2012-06-28 19:37:34]

lgtm

Okay, your description makes sense, thanks.

[commit-bot: I haz the power, 2012-06-29 05:35:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jknotten@chromium.org/10669033/5001

[commit-bot: I haz the power, 2012-06-29 06:29:40]

Try job failure for 10669033-5001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-02 06:51:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jknotten@chromium.org/10669033/5001

[commit-bot: I haz the power, 2012-07-02 08:25:34]

Change committed as 145124