lib/dom/scripts/systemnative.py - Issue 10669031: Support V8EnabledAtRuntime in constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10669031: Support V8EnabledAtRuntime in constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/dom/scripts/systemnative.py

diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py

index 57f9527d3447ee942253701880c2211293d3b8b6..b53e0086e0812512cdafcea0d67abacfca407a0f 100644

--- a/lib/dom/scripts/systemnative.py

+++ b/lib/dom/scripts/systemnative.py

@@ -315,6 +315,16 @@ class NativeImplementationGenerator(systembase.BaseGenerator):

' }',

FEATURE=self._interface.ext_attrs['synthesizedV8EnabledPerContext'])

+ if 'synthesizedV8EnabledAtRuntime' in self._interface.ext_attrs:

podivilov 2012/06/26 10:51:13 Shouldn't that be elif?

Anton Muhin 2012/06/26 12:16:35 Added assert instead On 2012/06/26 10:51:13, podi

+ raises_exceptions = True

+ self._cpp_impl_includes.add('"RuntimeEnabledFeatures.h"')

+ runtime_check = emitter.Format(

+ ' if (!RuntimeEnabledFeatures::$(FEATURE)Enabled()) {\n'

+ ' exception = Dart_NewString("Feature $FEATURE is not enabled");\n'

+ ' goto fail;\n'

+ ' }',

+ FEATURE=self._interface.ext_attrs['synthesizedV8EnabledAtRuntime'])

self._GenerateNativeCallback(callback_name='constructorCallback',

parameter_definitions=parameter_definitions_emitter.Fragments(),

needs_receiver=False, invocation=invocation,