Issue 10669023: Start consolidating non-port specific code to ui/base/dialogs.

Issue 10669023: Start consolidating non-port specific code to ui/base/dialogs. (Closed)

Created:
8 years, 6 months ago by Elliot Glaysher

Modified:
8 years, 6 months ago

Reviewers:
satorux1, sky

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, jochen+watch-content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Start consolidating non-port specific code to ui/base/dialogs. This moves content::SelectedFileInfo (what the select dialog outputs) and BaseShellDialog to ui/base/dialogs/. (This was split off from https://chromiumcodereview.appspot.com/10667026/ because that patch is getting huge.) BUG=134529 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144199

Patch Set 1 #

Patch Set 2 : clenaup #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -132 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/file_select_helper.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/file_select_helper.cc	View		8 chunks	+12 lines, -12 lines	0 comments	Download
D	chrome/browser/ui/base_shell_dialog.h	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/gtk/select_file_dialog_impl_gtk.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/select_file_dialog.h	View		4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/select_file_dialog.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/base_shell_dialog_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/color_chooser_dialog.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/select_file_dialog_extension.h	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/select_file_dialog_extension.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/select_file_dialog_extension_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/common/view_messages.h	View		4 chunks	+3 lines, -3 lines	0 comments	Download
M	content/content_common.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/browser/render_view_host.h	View		3 chunks	+5 lines, -2 lines	0 comments	Download
D	content/public/common/selected_file_info.h	View		1 chunk	+0 lines, -39 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
A +	ui/base/dialogs/base_shell_dialog.h	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download
A +	ui/base/dialogs/selected_file_info.h	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	ui/ui.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

content lgtm

Expand Messages | Collapse Messages