Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 10669015: Fix key state. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Fix key state. -canBecomeKeyView: = "participates in Full Keyboard Access". BookmarkButton shouldn't say "yes" when it means to say no. BUG=85691, 100866 TEST=fixes both bugs! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144036

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-25 21:29:56 UTC) #1
Robert Sesek
LGTM https://chromiumcodereview.appspot.com/10669015/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm (right): https://chromiumcodereview.appspot.com/10669015/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm#newcode364 chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm:364: return false; nit: NO
8 years, 6 months ago (2012-06-25 21:34:28 UTC) #2
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/10669015/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm (right): https://chromiumcodereview.appspot.com/10669015/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm#newcode364 chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm:364: return false; On 2012/06/25 21:34:28, rsesek wrote: > nit: ...
8 years, 6 months ago (2012-06-25 21:36:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10669015/4001
8 years, 6 months ago (2012-06-25 21:36:45 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-25 22:35:26 UTC) #5
Change committed as 144036

Powered by Google App Engine
This is Rietveld 408576698