content/shell/shell_access_token_store.cc - Issue 10669009: Add ShellAccessTokenStore to content_shell

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/shell_access_token_store.cc

Issue 10669009: Add ShellAccessTokenStore to content_shell (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/shell/shell_access_token_store.h"

	6 #include "chrome/browser/browser_process.h"
	jochen (gone - plz use gerrit) 2012/06/25 15:36:44 not needed? not needed? John Knottenbelt 2012/06/26 07:46:15 Done. Show quoted text On 2012/06/25 15:36:44, jochen wrote: > not needed? Done.
	7

	8 ShellAccessTokenStore::ShellAccessTokenStore(

	9 net::URLRequestContextGetter* system_request_context)

	10 : system_request_context_(system_request_context) {

	11 }

	12

	13 void ShellAccessTokenStore::LoadAccessTokens(

	14 const LoadAccessTokensCallbackType& callback) {

	15 callback.Run(AccessTokenSet(), system_request_context_);
	bulach 2012/06/25 15:28:39 hmm... does the caller expect the callback to be e hmm... does the caller expect the callback to be executed this soon? should we yield the callstack? John Knottenbelt 2012/06/26 07:46:15 Good point, chrome access token store will yield t Good point, chrome access token store will yield the call stack, so I think we should be consistent. On 2012/06/25 15:28:39, bulach wrote: Show quoted text > hmm... does the caller expect the callback to be executed this soon? should we > yield the callstack?
	16 }

	17

	18 void ShellAccessTokenStore::SaveAccessToken(

	19 const GURL& server_url, const string16& access_token) {

	20 }

OLD	NEW