Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 1066823004: PlzNavigate: improve tracking of improper subframe swap-out. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed NI::GetNavigationRequestForNodeForTesting signature. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl_unittest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc
index c1fce3c30fec4e115e8f926bf45b66b0ef7033ca..34ec08372558a22ff629a2219230ab1fe96ba199 100644
--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc
@@ -221,8 +221,10 @@ class NavigationControllerTest
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation)) {
FrameTreeNode* root = contents()->GetFrameTree()->root();
- NavigationRequest* navigation_request = static_cast<NavigatorImpl*>(
- root->navigator())->GetNavigationRequestForNodeForTesting(root);
+ NavigationRequest* navigation_request =
+ static_cast<NavigatorImpl*>(root->navigator())
+ ->GetNavigationRequestForNodeForTesting(
+ root->frame_tree_node_id());
return navigation_request != nullptr;
}
return process()->sink().GetFirstMessageMatching(FrameMsg_Navigate::ID)
@@ -233,8 +235,10 @@ class NavigationControllerTest
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation)) {
FrameTreeNode* root = contents()->GetFrameTree()->root();
- NavigationRequest* navigation_request = static_cast<NavigatorImpl*>(
- root->navigator())->GetNavigationRequestForNodeForTesting(root);
+ NavigationRequest* navigation_request =
+ static_cast<NavigatorImpl*>(root->navigator())
+ ->GetNavigationRequestForNodeForTesting(
+ root->frame_tree_node_id());
CHECK(navigation_request);
return navigation_request->common_params().url;
}
« no previous file with comments | « no previous file | content/browser/frame_host/navigator_impl.h » ('j') | content/browser/frame_host/navigator_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698