PlzNavigate: improve tracking of improper subframe swap-out.

content/browser/frame_host/navigator_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
 
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 69 matching lines @@
   void LogResourceRequestTime(base::TimeTicks timestamp,
                               const GURL& url) override;
   void LogBeforeUnloadTime(
       const base::TimeTicks& renderer_before_unload_start_time,
       const base::TimeTicks& renderer_before_unload_end_time) override;
   void CancelNavigation(FrameTreeNode* frame_tree_node) override;
   bool IsWaitingForBeforeUnloadACK(FrameTreeNode* frame_tree_node) override;
 
   // PlzNavigate
   // Returns the navigation request for a given node. Used in tests.
   NavigationRequest* GetNavigationRequestForNodeForTesting(

[nasko, 2015/04/14 16:06:29]

nit: I'd drop the "ForNode" part of the name, as it is no longer for a node, but
it looks up by id. It will make it easier to read and won't make it less clear
what it does.

[carlosk, 2015/04/23 16:10:12]

This method doesn't exist anymore.

-      FrameTreeNode* frame_tree_node);
+      int64 frame_tree_node_id);
 
  private:
   // Holds data used to track browser side navigation metrics.
   struct NavigationMetricsData;
 
   friend class NavigatorTestWithBrowserSideNavigation;
   ~NavigatorImpl() override;
 
   // Navigates to the given entry, which must be the pending entry.  Private
   // because all callers should use NavigateToPendingEntry.
@@ skipping 41 matching lines @@
   // different FrameTreeNodes, based on the frame_tree_node_id.
   typedef base::ScopedPtrHashMap<int64, NavigationRequest> NavigationRequestMap;
   NavigationRequestMap navigation_request_map_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigatorImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_