Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 10668050: Merge 120934 - Non-fixed length margins don't work with align=center (Closed)

Created:
8 years, 6 months ago by Julien - ping for review
Modified:
8 years, 6 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 120934 - Non-fixed length margins don't work with align=center https://bugs.webkit.org/show_bug.cgi?id=89626 Reviewed by Levi Weintraub. Source/WebCore: Tests: fast/block/negative-start-margin-align-center-percent.html fast/block/positive-margin-block-child-align-center-calc.html Calling Length::value() is a bad idea as it returns the *raw* value of the length. For percent and calculated length this is a bad idea as they bear not relation to the actual computed length. * rendering/RenderBox.cpp: (WebCore::RenderBox::computeInlineDirectionMargins): Fixed the code to use minimumValueForLength as this nicely takes care of the 'auto' case. LayoutTests: * fast/block/negative-start-margin-align-center-percent-expected.html: Added. * fast/block/negative-start-margin-align-center-percent.html: Added. * fast/block/positive-margin-block-child-align-center-calc-expected.html: Added. * fast/block/positive-margin-block-child-align-center-calc.html: Added. TBR=jchaffraix@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A + LayoutTests/fast/block/negative-start-margin-align-center-percent.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/block/negative-start-margin-align-center-percent-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/block/positive-margin-block-child-align-center-calc.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/block/positive-margin-block-child-align-center-calc-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
8 years, 6 months ago (2012-06-26 18:58:20 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698