Register JNI methods before running unittests on android.

Register JNI methods before running unittests on android.

A better way to implement: http://codereview.chromium.org/10658017/

BUG=125059
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144374

[Ryan Sleevi, 2012-06-26 18:52:02]

This approach LGTM, but please check with an appropriate Android reviewer.

The key concern would be that this delays JNI initialization from where it
currently happens (before base::CommandLine is ever instantiated) to now. I
can't imagine that causing any problems, but it's at least a change in
behaviour.

Also, make sure the Android bot is green ;)

[Jay Civelli, 2012-06-26 20:17:10]

lgtm

http://codereview.chromium.org/10668047/diff/10001/content/test/run_all_unitt...
File content/test/run_all_unittests.cc (right):

http://codereview.chromium.org/10668047/diff/10001/content/test/run_all_unitt...
content/test/run_all_unittests.cc:17: JNIEnv* env =
base::android::AttachCurrentThread();
Nit: do you need a local var?

http://codereview.chromium.org/10668047/diff/10001/net/base/run_all_unittests.cc
File net/base/run_all_unittests.cc (right):

http://codereview.chromium.org/10668047/diff/10001/net/base/run_all_unittests...
net/base/run_all_unittests.cc:28: JNIEnv* env =
base::android::AttachCurrentThread();
Nit: do you need a local var?

[nilesh, 2012-06-26 20:33:54]

http://codereview.chromium.org/10668047/diff/10001/content/test/run_all_unitt...
File content/test/run_all_unittests.cc (right):

http://codereview.chromium.org/10668047/diff/10001/content/test/run_all_unitt...
content/test/run_all_unittests.cc:17: JNIEnv* env =
base::android::AttachCurrentThread();
On 2012/06/26 20:17:11, Jay Civelli wrote:
> Nit: do you need a local var?
Removed

http://codereview.chromium.org/10668047/diff/10001/net/base/run_all_unittests.cc
File net/base/run_all_unittests.cc (right):

http://codereview.chromium.org/10668047/diff/10001/net/base/run_all_unittests...
net/base/run_all_unittests.cc:28: JNIEnv* env =
base::android::AttachCurrentThread();
On 2012/06/26 20:17:11, Jay Civelli wrote:
> Nit: do you need a local var?
Removed

[John Grabowski, 2012-06-26 21:41:20]

LGTM

[nilesh, 2012-06-26 23:59:28]

On 2012/06/26 21:41:20, John Grabowski wrote:
> LGTM

I have removed content changes (call to content::android::RegisterJni) as it was
causing link errors due to its dependency on content_utility. It needs more work
and I will send another CL for that.

[commit-bot: I haz the power, 2012-06-27 00:26:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10668047/19003

[commit-bot: I haz the power, 2012-06-27 00:54:10]

Try job failure for 10668047-19003 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-06-27 00:59:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10668047/19003

[commit-bot: I haz the power, 2012-06-27 02:21:03]

Change committed as 144374