Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chromeos/network/network_sms_handler.cc

Issue 10668026: Merge 143291 - Re-factor TraySms to use ash::SmsObserver instead of NetoworkSmsHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/sms_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_sms_handler.cc
===================================================================
--- chromeos/network/network_sms_handler.cc (revision 143914)
+++ chromeos/network/network_sms_handler.cc (working copy)
@@ -334,6 +334,10 @@
}
void NetworkSmsHandler::Init() {
+ // TODO(stevenjb): This code needs to monitor changes to Manager.Network
+ // so that devices added after Init() is called get added to device_handlers_.
+ // See: crbug.com/133416.
+
// Request network manager properties so that we can get the list of devices.
DBusThreadManager::Get()->GetFlimflamManagerClient()->GetProperties(
base::Bind(&NetworkSmsHandler::ManagerPropertiesCallback,
@@ -381,6 +385,7 @@
(*iter)->GetAsString(&device_path);
if (!device_path.empty()) {
// Request device properties.
+ VLOG(1) << "GetDeviceProperties: " << device_path;
DBusThreadManager::Get()->GetFlimflamDeviceClient()->GetProperties(
dbus::ObjectPath(device_path),
base::Bind(&NetworkSmsHandler::DevicePropertiesCallback,
@@ -394,8 +399,10 @@
const std::string& device_path,
DBusMethodCallStatus call_status,
const base::DictionaryValue& properties) {
- if (call_status != DBUS_METHOD_CALL_SUCCESS)
+ if (call_status != DBUS_METHOD_CALL_SUCCESS) {
+ LOG(ERROR) << "NetworkSmsHandler: ERROR: " << call_status;
return;
+ }
std::string device_type;
if (!properties.GetStringWithoutPathExpansion(
« no previous file with comments | « chrome/browser/chromeos/sms_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698