Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10668021: Distinguish statement and expression foreign code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/native_handler.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index 2cc1d008cc818688ac562a00ca038328ad9d7910..e8e30fc5bb9ba869196855dd182531019ff96e3f 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -1401,7 +1401,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
for (HInstruction instruction = start.first;
instruction != start.last;
instruction = instruction.next) {
- if (instruction.isStatement()) {
+ if (instruction.isStatement) {
if (!updateKind(ONE_STATEMENT)) return MULTIPLE_STATEMENTS;
} else if (!isGenerateAtUseSite(instruction)) {
if (!updateKind(ONE_EXPRESSION)) return MULTIPLE_STATEMENTS;
@@ -1410,7 +1410,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
HInstruction last = start.last;
if (last is !HGoto) {
- if (!updateKind(last.isStatement() ? ONE_STATEMENT : ONE_EXPRESSION)) {
+ if (!updateKind(last.isStatement ? ONE_STATEMENT : ONE_EXPRESSION)) {
return MULTIPLE_STATEMENTS;
}
}
« no previous file with comments | « lib/compiler/implementation/native_handler.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698