Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10668009: UI refinement for left/right ash tray and bubble. (Closed)

Created:
8 years, 6 months ago by jennyz
Modified:
8 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

UI refinement for left/right ash tray and bubble. Fix a bug which caused the cutoff the status area right edge in vertical alignment. Adjust ash tray status area and bubble position in vertical alignment. Adjust layout and text color of vertical clock UI. BUG=127577 TEST=Ash tray status and bubble should look right for left/right launcher. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146003

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -67 lines) Patch
M ash/system/date/date_view.h View 2 chunks +11 lines, -5 lines 0 comments Download
M ash/system/date/date_view.cc View 6 chunks +58 lines, -24 lines 0 comments Download
M ash/system/date/tray_date.cc View 2 chunks +1 line, -12 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray.cc View 5 chunks +36 lines, -14 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ash/system/tray/tray_constants.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/system/tray/tray_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jennyz
8 years, 6 months ago (2012-06-23 00:43:48 UTC) #1
sadrul
http://codereview.chromium.org/10668009/diff/1/ash/system/tray/tray_background_view.cc File ash/system/tray/tray_background_view.cc (left): http://codereview.chromium.org/10668009/diff/1/ash/system/tray/tray_background_view.cc#oldcode65 ash/system/tray/tray_background_view.cc:65: kPaddingFromRightEdgeOfScreenBottomAlignment)); Is this removal intentional?
8 years, 5 months ago (2012-07-03 13:07:47 UTC) #2
jennyz
http://codereview.chromium.org/10668009/diff/1/ash/system/tray/tray_background_view.cc File ash/system/tray/tray_background_view.cc (left): http://codereview.chromium.org/10668009/diff/1/ash/system/tray/tray_background_view.cc#oldcode65 ash/system/tray/tray_background_view.cc:65: kPaddingFromRightEdgeOfScreenBottomAlignment)); On 2012/07/03 13:07:47, sadrul wrote: > Is this ...
8 years, 5 months ago (2012-07-10 17:26:56 UTC) #3
sadrul
SG. LGTM
8 years, 5 months ago (2012-07-10 22:44:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/10668009/4001
8 years, 5 months ago (2012-07-10 22:56:33 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 00:14:20 UTC) #6 
Change committed as 146003

Powered by Google App Engine
This is Rietveld 408576698