chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc - Issue 10667026: Start consolidating cross-port file selection code into ui/base/dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc

Issue 10667026: Start consolidating cross-port file selection code into ui/base/dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Attempt to fix win Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options2/certificate_manager_handler2.cc ('k') | chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc

diff --git a/chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc b/chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc

index f9e043d472f807d663e05ca23a8c32fbd17f5ff4..e3fe6ef346ff94c2ea300581d787412a41e419f8 100644

--- a/chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc

+++ b/chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc

@@ -20,6 +20,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_window.h"

+#include "chrome/browser/ui/chrome_select_file_policy.h"

#include "chrome/browser/ui/webui/web_ui_util.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_paths.h"

@@ -139,8 +140,8 @@ void ChangePictureOptionsHandler::SendDefaultImages() {

void ChangePictureOptionsHandler::HandleChooseFile(const ListValue* args) {

DCHECK(args && args->empty());

- if (!select_file_dialog_.get())

- select_file_dialog_ = SelectFileDialog::Create(this);

+ select_file_dialog_ = SelectFileDialog::Create(

+ this, new ChromeSelectFilePolicy(web_ui()->GetWebContents()));

FilePath downloads_path;

if (!PathService::Get(chrome::DIR_DEFAULT_DOWNLOADS, &downloads_path)) {

@@ -159,7 +160,6 @@ void ChangePictureOptionsHandler::HandleChooseFile(const ListValue* args) {

&file_type_info,

FILE_PATH_LITERAL(""),

- web_ui()->GetWebContents(),

GetBrowserWindow(),

NULL);

}