chrome/browser/ui/webui/extensions/pack_extension_handler.cc - Issue 10667026: Start consolidating cross-port file selection code into ui/base/dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

Issue 10667026: Start consolidating cross-port file selection code into ui/base/dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Attempt to fix win Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | chrome/browser/ui/webui/options2/browser_options_handler2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

index 7df93cb2c607694280ea4fa786f56936240fb4ea..d97814f0129a908bbf9096d30c5bbd753d29950f 100644

--- a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

+++ b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/webui/extensions/pack_extension_handler.h"

#include "chrome/browser/extensions/extension_creator.h"

+#include "chrome/browser/ui/chrome_select_file_policy.h"

#include "base/bind.h"

#include "base/utf_string_conversions.h"

#include "content/public/browser/web_contents.h"

@@ -177,11 +178,13 @@ void PackExtensionHandler::HandleSelectFilePathMessage(

NOTREACHED();

}

- load_extension_dialog_ = SelectFileDialog::Create(this);

+ load_extension_dialog_ = SelectFileDialog::Create(

+ this, new ChromeSelectFilePolicy(web_ui()->GetWebContents()));

load_extension_dialog_->SelectFile(

type, select_title, FilePath(), &info, file_type_index,

- FILE_PATH_LITERAL(""), web_ui()->GetWebContents(),

- web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(), NULL);

+ FILE_PATH_LITERAL(""),

+ web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(),

+ NULL);

}

void PackExtensionHandler::ShowAlert(const std::string& message) {