Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5636)

Unified Diff: chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc

Issue 10667026: Start consolidating cross-port file selection code into ui/base/dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Attempt to fix win Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/select_file_dialog_impl_gtk.cc ('k') | chrome/browser/ui/select_file_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc
diff --git a/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc b/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc
index b1c1c13e2bbde41a319f8c602732c0a41d8f0bd0..3ae16a25e47f684b088d968a10dbaf66ac7fc1b4 100644
--- a/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc
+++ b/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc
@@ -16,6 +16,8 @@
#include "base/threading/thread_restrictions.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/ui/gtk/select_file_dialog_impl.h"
+
+// TODO(erg): Move all of this into WorkerPool.
#include "content/public/browser/browser_thread.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
@@ -41,6 +43,7 @@ const char kKdialogBinary[] = "kdialog";
class SelectFileDialogImplKDE : public SelectFileDialogImpl {
public:
SelectFileDialogImplKDE(Listener* listener,
+ ui::SelectFilePolicy* policy,
base::nix::DesktopEnvironment desktop);
protected:
@@ -156,14 +159,17 @@ bool SelectFileDialogImpl::CheckKDEDialogWorksOnUIThread() {
// static
SelectFileDialogImpl* SelectFileDialogImpl::NewSelectFileDialogImplKDE(
- Listener* listener, base::nix::DesktopEnvironment desktop) {
- return new SelectFileDialogImplKDE(listener, desktop);
+ Listener* listener,
+ ui::SelectFilePolicy* policy,
+ base::nix::DesktopEnvironment desktop) {
+ return new SelectFileDialogImplKDE(listener, policy, desktop);
}
SelectFileDialogImplKDE::SelectFileDialogImplKDE(
Listener* listener,
+ ui::SelectFilePolicy* policy,
base::nix::DesktopEnvironment desktop)
- : SelectFileDialogImpl(listener),
+ : SelectFileDialogImpl(listener, policy),
desktop_(desktop) {
DCHECK(desktop_ == base::nix::DESKTOP_ENVIRONMENT_KDE3 ||
desktop_ == base::nix::DESKTOP_ENVIRONMENT_KDE4);
« no previous file with comments | « chrome/browser/ui/gtk/select_file_dialog_impl_gtk.cc ('k') | chrome/browser/ui/select_file_dialog.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698