Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: src/liveedit.cc

Issue 10667025: Revert 11927 "Fix liveedit heap traversal bug with write barrier" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/liveedit.cc
diff --git a/src/liveedit.cc b/src/liveedit.cc
index d99c4a07ed31fd0bbed7db9e15682385cef2af6a..80e18bbbff9a9274e04f6fdd628aa671d414516b 100644
--- a/src/liveedit.cc
+++ b/src/liveedit.cc
@@ -968,14 +968,6 @@ class ReplacingVisitor : public ObjectVisitor {
static void ReplaceCodeObject(Code* original, Code* substitution) {
ASSERT(!HEAP->InNewSpace(substitution));
- // Perform a full GC in order to ensure that we are not in the middle of an
- // incremental marking phase when we are replacing the code object.
- // Since we are not in an incremental marking phase we can write pointers
- // to code objects (that are never in new space) without worrying about
- // write barriers.
- HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask,
- "liveedit.cc ReplaceCodeObject");
-
AssertNoAllocation no_allocations_please;
ReplacingVisitor visitor(original, substitution);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698