Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 10667006: Revert 143782 - Use a better registration suffix that will always be unique while respecting the MS… (Closed)

Created:
8 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Revert 143782 - Use a better registration suffix that will always be unique while respecting the MSDN rules. (Triggered assertion failures in browser_tests blocking WebKit rolls.) The suffix will now be the base32 encoding of the md5 hash of the user's username. This is always unique and can be determined many times deterministically without I/O access (as opposed to other methods we considered). It respects all MSDN constraint for properties onto which it is appended. This replaces the prior-style username suffixes for new installs. Old-style suffixes (i.e. unsuffixed and username suffixed) will however be kept as is through future updates. Design doc: https://docs.google.com/a/chromium.org/document/d/1qmcV3uYBh3JwvXhYkI7asg0nN7KfVMWVOzND4p0jQ3E/edit BUG=133810 TEST= http://goo.gl/ZZ7gE installer_util_unittests.exe --gtest_filter=ShellUtilTest.* Review URL: https://chromiumcodereview.appspot.com/10617002 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -216 lines) Patch
M chrome/installer/util/shell_util.h View 3 chunks +2 lines, -14 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 12 chunks +35 lines, -172 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 8 chunks +7 lines, -30 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Russell (switch to Gerrit)
8 years, 6 months ago (2012-06-24 13:11:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698