Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10667002: Make the serialization of IPC::Messages inside other IPC::Messages independent (Closed)

Created:
8 years, 6 months ago by brettw
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Make the serialization of IPC::Messages inside other IPC::Messages independent of the platform. This is necessary for sending nested messages between nacl (which the IPC system thinks is posix and so has extra header goo) and a Windows client app (which doesn't have this stuff). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144840

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : fix 64-bit #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -11 lines) Patch
M base/pickle.h View 2 chunks +13 lines, -0 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_message.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M ipc/ipc_message.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 2 1 chunk +31 lines, -10 lines 0 comments Download
A ipc/ipc_message_utils_unittest.cc View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
8 years, 6 months ago (2012-06-22 21:35:22 UTC) #1
darin (slow to review)
LGTM https://chromiumcodereview.appspot.com/10667002/diff/1/ipc/ipc_message.h File ipc/ipc_message.h (right): https://chromiumcodereview.appspot.com/10667002/diff/1/ipc/ipc_message.h#newcode156 ipc/ipc_message.h:156: // This is used when deserializing nested messages. ...
8 years, 6 months ago (2012-06-22 21:42:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/10667002/5001
8 years, 6 months ago (2012-06-22 22:36:26 UTC) #3
commit-bot: I haz the power
Try job failure for 10667002-5001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-22 23:23:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/10667002/7004
8 years, 5 months ago (2012-06-28 19:56:01 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-28 22:20:17 UTC) #6
Try job failure for 10667002-7004 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698