Issue 106663007: When clearing a field make the field state "does not exist"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106663007: When clearing a field make the field state "does not exist" (Closed)

Created:
7 years ago by Søren Gjesse

Modified:
7 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart-protobuf.git@master

Visibility:
Public.

More Reviews

Description

When clearing a field make the field state "does not exist" This does not change the fact that the default value is returned when the field is cleared. Tests for this in the dart-protoc-plugin package. R=sigmund@google.com BUG=https://github.com/dart-lang/dart-protobuf/issues/17 Committed: https://github.com/dart-lang/protobuf/commit/189e461

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -13 lines)			Patch
	M	lib/generated_message.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years ago (2013-12-10 07:33:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r189e461 (presubmit successful).

Expand Messages | Collapse Messages