Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10666052: Revert "Implement override checks." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/apiimpl.dart ('k') | lib/compiler/implementation/dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compiler.dart
diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart
index 5cb19337cb4fcc308c118fca646646309eb21ecd..6a78ae5e1f127347aa970adbc7507e675cef653c 100644
--- a/lib/compiler/implementation/compiler.dart
+++ b/lib/compiler/implementation/compiler.dart
@@ -303,8 +303,6 @@ class Compiler implements DiagnosticListener {
static final int PHASE_RECOMPILING = 3;
int phase;
- bool compilationFailed = false;
-
Compiler([this.tracer = const Tracer(),
this.enableTypeAssertions = false,
this.enableUserAssertions = false,
@@ -550,8 +548,6 @@ class Compiler implements DiagnosticListener {
processQueue(enqueuer.resolution, main);
log('Resolved ${enqueuer.resolution.resolvedElements.length} elements.');
- if (compilationFailed) return;
-
log('Compiling...');
phase = PHASE_COMPILING;
processQueue(enqueuer.codegen, main);
@@ -561,8 +557,6 @@ class Compiler implements DiagnosticListener {
processRecompilationQueue(enqueuer.codegen);
log('Compiled ${codegenWorld.generatedCode.length} methods.');
- if (compilationFailed) return;
-
backend.assembleProgram();
checkQueues();
@@ -761,7 +755,7 @@ class Compiler implements DiagnosticListener {
}
SourceSpan span = spanFromNode(node);
- reportDiagnostic(span, 'Warning: $message', api.Diagnostic.WARNING);
+ reportDiagnostic(span, 'Warning: $message', api.Diagnostic.WARNING );
}
reportError(Node node, var message) {
@@ -770,14 +764,6 @@ class Compiler implements DiagnosticListener {
throw new CompilerCancelledException(message.toString());
}
- void reportMessage(SourceSpan span,
- Diagnostic message,
- api.Diagnostic kind) {
- // TODO(ahe): The names Diagnostic and api.Diagnostic are in
- // conflict. Fix it.
- reportDiagnostic(span, "$message", kind);
- }
-
abstract void reportDiagnostic(SourceSpan span, String message,
api.Diagnostic kind);
« no previous file with comments | « lib/compiler/implementation/apiimpl.dart ('k') | lib/compiler/implementation/dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698