Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/layout.cc

Issue 10666034: Correct overlapping layout ranges. (Closed) Base URL: http://ots.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/layout.cc
===================================================================
--- src/layout.cc (revision 92)
+++ src/layout.cc (working copy)
@@ -394,7 +394,12 @@
!subtable.ReadU16(&start_coverage_index)) {
return OTS_FAILURE();
}
- if (start > end || (last_end && start <= last_end)) {
+
+ // Some of the Adobe Pro fonts have ranges that overlap by one element: the
+ // start of one range is equal to the end of the previous range. Therefore
+ // the < in the following condition should be <= were it not for this.
+ // See crbug.com/29937.
bashi 2012/06/25 22:23:31 crbug.com/134135 ?
agl 2012/06/26 14:43:27 Done. Thanks, that was the other bug that I was lo
+ if (start > end || (last_end && start < last_end)) {
OTS_WARNING("glyph range is overlapping.");
return OTS_FAILURE();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698