Issue 10666034: Correct overlapping layout ranges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10666034: Correct overlapping layout ranges. (Closed)

Created:
8 years, 6 months ago by agl

Modified:
8 years, 6 months ago

Reviewers:
bashi

CC:
chromium-reviews

Base URL:
http://ots.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Ignore layout ranges that overlap by a single element. BUG=134135

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/layout.cc	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bashi

LGTM. Thank you for the patch? https://chromiumcodereview.appspot.com/10666034/diff/4001/src/layout.cc File src/layout.cc (right): https://chromiumcodereview.appspot.com/10666034/diff/4001/src/layout.cc#newcode401 src/layout.cc:401: // See crbug.com/29937. ...

8 years, 6 months ago (2012-06-25 22:23:31 UTC) #2

agl

8 years, 6 months ago (2012-06-26 14:43:27 UTC) #3

https://chromiumcodereview.appspot.com/10666034/diff/4001/src/layout.cc
File src/layout.cc (right):

https://chromiumcodereview.appspot.com/10666034/diff/4001/src/layout.cc#newco...
src/layout.cc:401: // See crbug.com/29937.
On 2012/06/25 22:23:31, bashik wrote:
> crbug.com/134135 ?

Done. Thanks, that was the other bug that I was looking at.

Expand Messages | Collapse Messages

Issue 10666034: Correct overlapping layout ranges. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages