Issue 10666018: Add eight more bits of entropy to the sandbox intercept trampoline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10666018: Add eight more bits of entropy to the sandbox intercept trampoline (Closed)

Created:
8 years, 6 months ago by jschuh

Modified:
8 years, 6 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews

Base URL:
https://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Add eight more bits of entropy to the sandbox intercept trampoline Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144031

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -7 lines)			Patch
	M	sandbox/src/interception.cc	View	1 2 3	2 chunks	+41 lines, -5 lines	0 comments	Download
	M	sandbox/src/target_process.cc	View	1 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jschuh

We already have six bits of entropy, but people are poking at this and noticed ...

8 years, 6 months ago (2012-06-24 23:52:08 UTC) #1

rvargas (doing something else)

LGTM http://codereview.chromium.org/10666018/diff/12001/sandbox/src/interception.cc File sandbox/src/interception.cc (right): http://codereview.chromium.org/10666018/diff/12001/sandbox/src/interception.cc#newcode395 sandbox/src/interception.cc:395: // Split the base and offset along page ...

8 years, 6 months ago (2012-06-25 18:25:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/10666018/13001

8 years, 6 months ago (2012-06-25 20:57:20 UTC) #3

Change committed as 144031

Expand Messages | Collapse Messages

Issue 10666018: Add eight more bits of entropy to the sandbox intercept trampoline (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages