Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10666009: Added already_open column to chrome://suggestions-internals. (Closed)

Created:
8 years, 6 months ago by Rune Fevang
Modified:
8 years, 5 months ago
Reviewers:
macourteau, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Added already_open column to chrome://suggestions-internals. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144883

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 4

Patch Set 3 : Addressed comments #

Total comments: 4

Patch Set 4 : Addressed estade comments. #

Patch Set 5 : Fixed unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -16 lines) Patch
M chrome/browser/resources/suggestions_internals/suggestions_internals.css View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M chrome/browser/resources/suggestions_internals/suggestions_internals.js View 3 chunks +17 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_combiner.h View 1 2 3 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_combiner.cc View 1 2 3 4 chunks +43 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_combiner_unittest.cc View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui_handler.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Rune Fevang
+macourteau
8 years, 6 months ago (2012-06-22 23:08:57 UTC) #1
macourteau
lgtm with nits. http://chromiumcodereview.appspot.com/10666009/diff/2001/chrome/browser/resources/suggestions_internals/suggestions_internals.css File chrome/browser/resources/suggestions_internals/suggestions_internals.css (right): http://chromiumcodereview.appspot.com/10666009/diff/2001/chrome/browser/resources/suggestions_internals/suggestions_internals.css#newcode28 chrome/browser/resources/suggestions_internals/suggestions_internals.css:28: text-align: center; Nit: you might want ...
8 years, 6 months ago (2012-06-26 19:21:49 UTC) #2
Rune Fevang
http://chromiumcodereview.appspot.com/10666009/diff/2001/chrome/browser/resources/suggestions_internals/suggestions_internals.css File chrome/browser/resources/suggestions_internals/suggestions_internals.css (right): http://chromiumcodereview.appspot.com/10666009/diff/2001/chrome/browser/resources/suggestions_internals/suggestions_internals.css#newcode28 chrome/browser/resources/suggestions_internals/suggestions_internals.css:28: text-align: center; On 2012/06/26 19:21:49, macourteau wrote: > Nit: ...
8 years, 5 months ago (2012-06-27 00:28:59 UTC) #3
Rune Fevang
estade: Could you do an owners review please?
8 years, 5 months ago (2012-06-27 00:30:05 UTC) #4
Evan Stade
lgtm http://chromiumcodereview.appspot.com/10666009/diff/9001/chrome/browser/ui/webui/ntp/suggestions_combiner.cc File chrome/browser/ui/webui/ntp/suggestions_combiner.cc (right): http://chromiumcodereview.appspot.com/10666009/diff/9001/chrome/browser/ui/webui/ntp/suggestions_combiner.cc#newcode162 chrome/browser/ui/webui/ntp/suggestions_combiner.cc:162: continue; \n http://chromiumcodereview.appspot.com/10666009/diff/9001/chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui_handler.h File chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui_handler.h (right): http://chromiumcodereview.appspot.com/10666009/diff/9001/chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui_handler.h#newcode17 chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui_handler.h:17: ...
8 years, 5 months ago (2012-06-28 19:13:52 UTC) #5
Rune Fevang
http://chromiumcodereview.appspot.com/10666009/diff/9001/chrome/browser/ui/webui/ntp/suggestions_combiner.cc File chrome/browser/ui/webui/ntp/suggestions_combiner.cc (right): http://chromiumcodereview.appspot.com/10666009/diff/9001/chrome/browser/ui/webui/ntp/suggestions_combiner.cc#newcode162 chrome/browser/ui/webui/ntp/suggestions_combiner.cc:162: continue; On 2012/06/28 19:13:52, Evan Stade wrote: > \n ...
8 years, 5 months ago (2012-06-28 21:37:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/10666009/15001
8 years, 5 months ago (2012-06-28 21:38:10 UTC) #7
commit-bot: I haz the power
Try job failure for 10666009-15001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-06-28 22:06:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/10666009/20004
8 years, 5 months ago (2012-06-28 23:31:52 UTC) #9
commit-bot: I haz the power
Try job failure for 10666009-20004 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-06-29 00:05:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/10666009/20004
8 years, 5 months ago (2012-06-29 03:51:41 UTC) #11
commit-bot: I haz the power
Try job failure for 10666009-20004 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-06-29 04:40:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/10666009/20004
8 years, 5 months ago (2012-06-29 04:43:27 UTC) #13
commit-bot: I haz the power
8 years, 5 months ago (2012-06-29 07:11:08 UTC) #14 
Change committed as 144883

Powered by Google App Engine
This is Rietveld 408576698