Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: build/android/device_status_check.py

Issue 10665012: Minor fixes to android device_status script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/buildbot_report.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/device_status_check.py
diff --git a/build/android/device_status_check.py b/build/android/device_status_check.py
index 267c1d9d1685a546666fe420ce276ea4c82144dd..673fbe83ed3df725798632ee1e77dfb2de7fbd8c 100755
--- a/build/android/device_status_check.py
+++ b/build/android/device_status_check.py
@@ -10,6 +10,7 @@ import optparse
import os
import sys
+from pylib import buildbot_report
from pylib.android_commands import GetAttachedDevices
from pylib.cmd_helper import GetCmdOutput
@@ -70,8 +71,9 @@ def CheckForMissingDevices(options, adb_online_devs):
missing_devs = list(set(last_devices) - set(adb_online_devs))
if missing_devs:
- print '@@@STEP_WARNINGS@@@'
- print '@@@STEP_SUMMARY_TEXT@%s not detected.@@@' % missing_devs
+ buildbot_report.PrintWarning()
+ buildbot_report.PrintSummaryText(
+ '%d devices not detected.' % len(missing_devs))
print 'Current online devices: %s' % adb_online_devs
print '%s are no longer visible. Were they removed?\n' % missing_devs
print 'SHERIFF: See go/chrome_device_monitor'
@@ -80,9 +82,10 @@ def CheckForMissingDevices(options, adb_online_devs):
print GetCmdOutput(['adb', 'devices'])
else:
new_devs = set(adb_online_devs) - set(last_devices)
- if new_devs:
- print '@@@STEP_WARNINGS@@@'
- print '@@@STEP_SUMMARY_TEXT@New devices detected :-)@@@'
+ if new_devs and os.path.exists(last_devices_path):
+ buildbot_report.PrintWarning()
+ buildbot_report.PrintSummaryText(
+ '%d new devices detected' % len(new_devs))
print ('New devices detected %s. And now back to your '
'regularly scheduled program.' % list(new_devs))
@@ -101,8 +104,8 @@ def main():
options, args = parser.parse_args()
if args:
parser.error('Unknown options %s' % args)
+ buildbot_report.PrintNamedStep('Device Status Check')
devices = GetAttachedDevices()
-
types, builds, reports = [], [], []
if devices:
types, builds, reports = zip(*[DeviceInfo(dev) for dev in devices])
@@ -110,9 +113,8 @@ def main():
unique_types = list(set(types))
unique_builds = list(set(builds))
- print ('@@@BUILD_STEP Device Status Check - '
- '%d online devices, types %s, builds %s@@@'
- % (len(devices), unique_types, unique_builds))
+ buildbot_report.PrintMsg('Online devices: %d. Device types %s, builds %s'
+ % (len(devices), unique_types, unique_builds))
print '\n'.join(reports)
CheckForMissingDevices(options, devices)
« no previous file with comments | « no previous file | build/android/pylib/buildbot_report.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698