ppapi: Add test for touch-event support.

ppapi: Add test for touch-event support.

BUG=128236
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144796

[sadrul, 2012-06-23 01:35:10]

Hi! I added some tests. For the new tests to work, I had to make sure the plugin
doesn't remove itself at the end. So I added a TestingInstance::remove_plugin_
to decide whether the plugin should be removed at the end of the test or not.
The added tests pass locally. Once the webkit patch gets gardened in, I will run
it through the trybots. But does this approach look acceptable?

[sadrul, 2012-06-25 05:26:20]

On 2012/06/23 01:35:10, sadrul wrote:
> Hi! I added some tests. For the new tests to work, I had to make sure the
plugin
> doesn't remove itself at the end. So I added a TestingInstance::remove_plugin_
> to decide whether the plugin should be removed at the end of the test or not.
> The added tests pass locally. Once the webkit patch gets gardened in, I will
run
> it through the trybots. But does this approach look acceptable?

The trybots are all super happy!

[brettw, 2012-06-25 23:30:51]

Normally if you just load the test page with the test plugin loaded, it will run
all the tests in a category. The tests you've added don't work that way, and
since they aren't removed at the end of the test, I think it may mess up
subsequent tests.

Can we have a mode where your new testcases only run if the exact test name is
specified as the filter to avoid this problem?

http://codereview.chromium.org/10665007/diff/5002/ppapi/tests/test_input_even...
File ppapi/tests/test_input_event.cc (right):

http://codereview.chromium.org/10665007/diff/5002/ppapi/tests/test_input_even...
ppapi/tests/test_input_event.cc:292: std::string
TestInputEvent::TestAcceptTouchEvent_1() {
Can you add a comment above here explaining how this works? Normally the "Ppapi"
tests can just be loaded in a browser, but yours require that they be run in the
test framework. So we should be sure to explain this and what the calling code
is looking for us to do.

[sadrul, 2012-06-28 16:38:04]

http://codereview.chromium.org/10665007/diff/5002/ppapi/tests/test_input_even...
File ppapi/tests/test_input_event.cc (right):

http://codereview.chromium.org/10665007/diff/5002/ppapi/tests/test_input_even...
ppapi/tests/test_input_event.cc:292: std::string
TestInputEvent::TestAcceptTouchEvent_1() {
On 2012/06/25 23:30:51, brettw wrote:
> Can you add a comment above here explaining how this works? Normally the
"Ppapi"
> tests can just be loaded in a browser, but yours require that they be run in
the
> test framework. So we should be sure to explain this and what the calling code
> is looking for us to do.

Done.

[brettw, 2012-06-28 20:25:07]

lgtm

http://codereview.chromium.org/10665007/diff/21001/ppapi/tests/test_input_eve...
File ppapi/tests/test_input_event.cc (right):

http://codereview.chromium.org/10665007/diff/21001/ppapi/tests/test_input_eve...
ppapi/tests/test_input_event.cc:35: #define RUN_TEST_EXACT_MATCH(name,
test_filter) \
Can you add a comment here about what you're trying to do?

[sadrul, 2012-06-28 20:49:22]

Thanks!

http://codereview.chromium.org/10665007/diff/21001/ppapi/tests/test_input_eve...
File ppapi/tests/test_input_event.cc (right):

http://codereview.chromium.org/10665007/diff/21001/ppapi/tests/test_input_eve...
ppapi/tests/test_input_event.cc:35: #define RUN_TEST_EXACT_MATCH(name,
test_filter) \
On 2012/06/28 20:25:07, brettw wrote:
> Can you add a comment here about what you're trying to do?

Done.