Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: chrome/installer/util/browser_distribution_unittest.cc

Issue 10665002: Implement installation of the Chrome App Host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unittests. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 //
5 // Unit tests for BrowserDistribution class.
6
7 #include "chrome/installer/util/browser_distribution.h"
8 #include "chrome/installer/util/shell_util.h"
9 #include "testing/gtest/include/gtest/gtest.h"
10
11 // The distribution strings should not be empty. The unit tests are not linking
12 // with the chrome resources so we cannot test official build.
13 TEST(BrowserDistributionTest, StringsTest) {
14 for (size_t i = 0; i < BrowserDistribution::kNumProductTypes; ++i) {
15 BrowserDistribution* dist =
16 BrowserDistribution::GetSpecificDistribution(
17 BrowserDistribution::kProductTypes[i]);
18 ASSERT_TRUE(dist != NULL);
19 string16 name = dist->GetBaseAppName();
20 EXPECT_FALSE(name.empty());
21 string16 desc = dist->GetAppDescription();
22 EXPECT_FALSE(desc.empty());
23 string16 alt_name = dist->GetAlternateApplicationName();
24 EXPECT_FALSE(alt_name.empty());
25 }
26 }
27
28 // The shortcut strings obtained by the shell utility functions should not
29 // be empty or be the same.
30 TEST(BrowserDistributionTest, AlternateAndNormalShortcutName) {
31 string16 normal_name;
32 string16 alternate_name;
33 string16 appended_name_one;
34 string16 appended_name_two;
35 BrowserDistribution* dist = BrowserDistribution::GetDistribution();
36 EXPECT_TRUE(ShellUtil::GetChromeShortcutName(dist, false, L"",
37 &normal_name));
38 EXPECT_TRUE(ShellUtil::GetChromeShortcutName(dist, true, L"",
39 &alternate_name));
40 EXPECT_TRUE(ShellUtil::GetChromeShortcutName(dist, true, L"Sparky",
41 &appended_name_one));
42 EXPECT_TRUE(ShellUtil::GetChromeShortcutName(dist, true, L"Sparkles",
43 &appended_name_two));
44 EXPECT_NE(normal_name, alternate_name);
45 EXPECT_NE(appended_name_one, appended_name_two);
46 EXPECT_FALSE(normal_name.empty());
47 EXPECT_FALSE(alternate_name.empty());
48 EXPECT_FALSE(appended_name_one.empty());
49 EXPECT_FALSE(appended_name_two.empty());
50 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698