Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6178)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.h

Issue 10664037: Moved ExtensionMenuManager and ExtensionMenuItem into extensions namespace (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Merged with latest master Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/render_view_context_menu.h
diff --git a/chrome/browser/tab_contents/render_view_context_menu.h b/chrome/browser/tab_contents/render_view_context_menu.h
index 62025208badc81ccf8ef5076606aaa540f696a4c..7a051337d679a552da1908a265d6ace9ac44e6d5 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.h
+++ b/chrome/browser/tab_contents/render_view_context_menu.h
@@ -15,14 +15,13 @@
#include "base/observer_list.h"
#include "base/string16.h"
#include "chrome/browser/custom_handlers/protocol_handler_registry.h"
-#include "chrome/browser/extensions/extension_menu_manager.h"
+#include "chrome/browser/extensions/menu_manager.h"
#include "chrome/browser/tab_contents/render_view_context_menu_observer.h"
#include "content/public/common/context_menu_params.h"
#include "content/public/common/page_transition_types.h"
#include "ui/base/models/simple_menu_model.h"
#include "webkit/glue/window_open_disposition.h"
-class ExtensionMenuItem;
class PrintPreviewContextMenuObserver;
class Profile;
class SpellingMenuObserver;
@@ -35,6 +34,7 @@ class WebContents;
namespace extensions {
class Extension;
+class MenuItem;
}
namespace gfx {
@@ -178,8 +178,8 @@ class RenderViewContextMenu : public ui::SimpleMenuModel::Delegate,
int command_id,
ui::Accelerator* accelerator) = 0;
- // Attempts to get an ExtensionMenuItem given the id of a context menu item.
- ExtensionMenuItem* GetExtensionMenuItem(int id) const;
+ // Attempts to get an MenuItem given the id of a context menu item.
+ extensions::MenuItem* GetExtensionMenuItem(int id) const;
content::ContextMenuParams params_;
content::WebContents* source_web_contents_;
@@ -190,9 +190,8 @@ class RenderViewContextMenu : public ui::SimpleMenuModel::Delegate,
// True if we are showing for an external tab contents. The default is false.
bool external_;
- // Maps the id from a context menu item to the ExtensionMenuItem's internal
- // id.
- std::map<int, ExtensionMenuItem::Id> extension_item_map_;
+ // Maps the id from a context menu item to the MenuItem's internal id.
+ std::map<int, extensions::MenuItem::Id> extension_item_map_;
private:
friend class RenderViewContextMenuTest;
@@ -201,10 +200,10 @@ class RenderViewContextMenu : public ui::SimpleMenuModel::Delegate,
static bool IsInternalResourcesURL(const GURL& url);
static bool ExtensionContextAndPatternMatch(
const content::ContextMenuParams& params,
- ExtensionMenuItem::ContextList contexts,
+ extensions::MenuItem::ContextList contexts,
const URLPatternSet& target_url_patterns);
- static ExtensionMenuItem::List GetRelevantExtensionItems(
- const ExtensionMenuItem::List& items,
+ static extensions::MenuItem::List GetRelevantExtensionItems(
+ const extensions::MenuItem::List& items,
const content::ContextMenuParams& params,
Profile* profile,
bool can_cross_incognito);
@@ -241,7 +240,7 @@ class RenderViewContextMenu : public ui::SimpleMenuModel::Delegate,
// Used for recursively adding submenus of extension items.
void RecursivelyAppendExtensionItems(
- const std::vector<ExtensionMenuItem*>& items,
+ const std::vector<extensions::MenuItem*>& items,
bool can_cross_incognito,
ui::SimpleMenuModel* menu_model,
int* index);
« no previous file with comments | « chrome/browser/extensions/menu_manager_unittest.cc ('k') | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698