Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 10664002: Add support for drive files to chrome.fileBrowserHandler.selectFile (Closed)

Created:
8 years, 6 months ago by tbarzic
Modified:
8 years, 5 months ago
Reviewers:
Aaron Boodman, satorux1
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add support for drive files to chrome.fileBrowserHandler.selectFile first, we don't create file on disk when it is selected anymore (since we can't really know exact file path for drive files), we just setup permissions for the file. second, we have to give read permissions for drive cache paths as well in order to enable file reading. TEST=existing BUG=138089 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148292

Patch Set 1 #

Patch Set 2 : permissions for drive cache paths #

Patch Set 3 : . #

Patch Set 4 : update function description #

Patch Set 5 : update comments #

Patch Set 6 : rebase #

Patch Set 7 : api desc #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -51 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_handler_api.h View 1 2 3 4 5 6 7 3 chunks +17 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api.cc View 1 2 3 4 5 6 7 4 chunks +59 lines, -38 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handler.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tbarzic
8 years, 6 months ago (2012-06-23 01:17:01 UTC) #1
tbarzic
hshi, can you take a look at this (afaik, you're familiar enough with setting file ...
8 years, 5 months ago (2012-07-18 16:22:31 UTC) #2
tbarzic
just realized hshi is out this week.. satorux, could you take a look at this?
8 years, 5 months ago (2012-07-18 23:12:37 UTC) #3
satorux1
Could you file a bug about the problem you are solving?
8 years, 5 months ago (2012-07-19 16:17:03 UTC) #4
tbarzic
On 2012/07/19 16:17:03, satorux1 wrote: > Could you file a bug about the problem you ...
8 years, 5 months ago (2012-07-19 16:27:39 UTC) #5
satorux1
LGTM
8 years, 5 months ago (2012-07-19 16:44:54 UTC) #6
tbarzic
Aaron: ping?
8 years, 5 months ago (2012-07-24 17:12:28 UTC) #7
Aaron Boodman
LGTM Did you double-check that nobody is relying on the fact that files get created ...
8 years, 5 months ago (2012-07-24 21:36:40 UTC) #8
tbarzic
On 2012/07/24 21:36:40, Aaron Boodman wrote: > LGTM > > Did you double-check that nobody ...
8 years, 5 months ago (2012-07-25 00:45:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/10664002/23001
8 years, 5 months ago (2012-07-25 02:49:59 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 04:48:32 UTC) #11
Change committed as 148292

Powered by Google App Engine
This is Rietveld 408576698