Issue 10663032: [Sync] Disable search engines datatype by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10663032: [Sync] Disable search engines datatype by default. (Closed)

Created:
8 years, 6 months ago by Nicolas Zea

Modified:
8 years, 6 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), SteveT, dharani1

Base URL:
svn://svn.chromium.org/chrome/branches/1132/src/

Visibility:
Public.

More Reviews

Description

[Sync] Disable search engines datatype by default. We disable the search engines datatype temporarily due to the risk of the default search engine getting replaced incorrectly. BUG=132446 TEST=Adding/deleting search engines does not sync. New clients do not download any new search engines after signing in. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144108

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -7 lines)			Patch
M	chrome/browser/sync/profile_sync_components_factory_impl.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/sync_test.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

:( 

LGTM

Expand Messages | Collapse Messages