Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10663024: Run APK tests on the main thread. (Closed)

Created:
8 years, 6 months ago by nilesh
Modified:
8 years, 6 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Run APK tests on the main thread. Many tests rely on being run on the main thread. In this CL we post a delayed task to run tests on the main thread and do not block in onCreate(). This can cause ANR if the main test activity receives a touch event, but this should not happen. BUG=125059 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144038

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 1 3 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nilesh
8 years, 6 months ago (2012-06-25 20:49:44 UTC) #1
John Grabowski
LGTM http://codereview.chromium.org/10663024/diff/1/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java File testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java (right): http://codereview.chromium.org/10663024/diff/1/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java#newcode18 testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java:18: private static long RUN_TESTS_DELAY_IN_MS = 300; Comment why ...
8 years, 6 months ago (2012-06-25 20:51:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10663024/4001
8 years, 6 months ago (2012-06-25 21:26:24 UTC) #3
nilesh
http://codereview.chromium.org/10663024/diff/1/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java File testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java (right): http://codereview.chromium.org/10663024/diff/1/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java#newcode18 testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java:18: private static long RUN_TESTS_DELAY_IN_MS = 300; On 2012/06/25 20:51:37, ...
8 years, 6 months ago (2012-06-25 21:26:26 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-25 22:43:21 UTC) #5
Change committed as 144038

Powered by Google App Engine
This is Rietveld 408576698