Add tests for chrome.fileSystem app API.

Add tests for chrome.fileSystem app API.

BUG=132945
TEST=No testing required; automated tests added.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144017

[benwells, 2012-06-24 04:31:00]

chrome.fileSystem.getWritableFileEntry is not tested yet; I'm about to change
the way it works and will add tests for it then.

[kinuko, 2012-06-24 09:55:57]

Drive-by comments (no need to wait my another review)

http://codereview.chromium.org/10663014/diff/4002/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/file_system/open_existing/test.js
(right):

http://codereview.chromium.org/10663014/diff/4002/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/file_system/open_existing/test.js:20:
fileWriter.write(bb.getBlob('text/plain'));
Please use new Blob constructor instead:

new Blob(['HoHoHo!'], {type:'text/plain'})

http://codereview.chromium.org/10663014/diff/4002/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/file_system/save_existing/test.js
(right):

http://codereview.chromium.org/10663014/diff/4002/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/file_system/save_existing/test.js:38:
fileWriter.write(bb.getBlob('text/plain'));
ditto.

[asargent_no_longer_on_chrome, 2012-06-25 17:47:01]

LGTM

http://codereview.chromium.org/10663014/diff/2002/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.h (right):

http://codereview.chromium.org/10663014/diff/2002/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.h:24: // Allow picker
UI to be skipped in testing.
nit: It would be nice to have "ForTest" on these names, or maybe wrap them in an
inner classed named TestControl or something like that.

[benwells, 2012-06-25 19:07:21]

https://chromiumcodereview.appspot.com/10663014/diff/4002/chrome/test/data/ex...
File chrome/test/data/extensions/api_test/file_system/open_existing/test.js
(right):

https://chromiumcodereview.appspot.com/10663014/diff/4002/chrome/test/data/ex...
chrome/test/data/extensions/api_test/file_system/open_existing/test.js:20:
fileWriter.write(bb.getBlob('text/plain'));
On 2012/06/24 09:55:57, kinuko wrote:
> Please use new Blob constructor instead:
> 
> new Blob(['HoHoHo!'], {type:'text/plain'})

Done.

https://chromiumcodereview.appspot.com/10663014/diff/4002/chrome/test/data/ex...
File chrome/test/data/extensions/api_test/file_system/save_existing/test.js
(right):

https://chromiumcodereview.appspot.com/10663014/diff/4002/chrome/test/data/ex...
chrome/test/data/extensions/api_test/file_system/save_existing/test.js:38:
fileWriter.write(bb.getBlob('text/plain'));
On 2012/06/24 09:55:57, kinuko wrote:
> ditto.

Done.

https://chromiumcodereview.appspot.com/10663014/diff/2002/chrome/browser/exte...
File chrome/browser/extensions/api/file_system/file_system_api.h (right):

https://chromiumcodereview.appspot.com/10663014/diff/2002/chrome/browser/exte...
chrome/browser/extensions/api/file_system/file_system_api.h:24: // Allow picker
UI to be skipped in testing.
On 2012/06/25 17:47:01, Antony Sargent wrote:
> nit: It would be nice to have "ForTest" on these names, or maybe wrap them in
an
> inner classed named TestControl or something like that.
> 

Done.

[commit-bot: I haz the power, 2012-06-25 19:08:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/10663014/10002

[commit-bot: I haz the power, 2012-06-25 19:08:36]

Presubmit check for 10663014-10002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
 
chrome/test/data/extensions/api_test/file_system/get_display_path/background.js
\
  chrome/test/data/extensions/api_test/file_system/get_display_path/test.js \
  chrome/test/data/extensions/api_test/file_system/open_background/background.js
\
  chrome/test/data/extensions/api_test/file_system/open_cancel/background.js \
  chrome/test/data/extensions/api_test/file_system/open_cancel/test.js \
  chrome/test/data/extensions/api_test/file_system/open_existing/background.js \
  chrome/test/data/extensions/api_test/file_system/open_existing/test.js \
  chrome/test/data/extensions/api_test/file_system/save_background/background.js
\
  chrome/test/data/extensions/api_test/file_system/save_cancel/background.js \
  chrome/test/data/extensions/api_test/file_system/save_cancel/test.js \
  chrome/test/data/extensions/api_test/file_system/save_existing/background.js \
  chrome/test/data/extensions/api_test/file_system/save_existing/test.js \
  chrome/test/data/extensions/api_test/file_system/save_new/background.js \
  chrome/test/data/extensions/api_test/file_system/save_new/test.js

Presubmit checks took 1.3s to calculate.

[commit-bot: I haz the power, 2012-06-25 20:04:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/10663014/8037

[commit-bot: I haz the power, 2012-06-25 21:23:20]

Change committed as 144017