Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 10662056: Revert "Use a test specific macro to call JNI registrars during APK tests." (Closed)

Created:
8 years, 5 months ago by nilesh
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Revert "Use a test specific macro to call JNI registrars during APK tests." TBR=jam@chromium.org,jrg@chromium.org (The original CL was submitted with a TBR too, incorrectly categorized as a simple gyp change) This reverts commit 575ab5330492664079ea89804bec615d15ea3b33. We intend to do this using run_all_unittests.cc in individual suites. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -28 lines) Patch
M content/content_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -4 lines 0 comments Download
M testing/android/native_test_launcher.cc View 3 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nilesh
8 years, 5 months ago (2012-06-26 18:13:58 UTC) #1
Ryan Sleevi
LGTM ;)
8 years, 5 months ago (2012-06-26 18:34:40 UTC) #2
nilesh
8 years, 5 months ago (2012-06-26 18:36:19 UTC) #3
nilesh
I am going ahead with the revert.
8 years, 5 months ago (2012-06-26 18:39:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10662056/1
8 years, 5 months ago (2012-06-26 18:39:19 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-26 19:33:33 UTC) #6
Change committed as 144240

Powered by Google App Engine
This is Rietveld 408576698