Issue 10662045: Port r7868 (constant masking) to x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10662045: Port r7868 (constant masking) to x64. (Closed)

Created:
8 years, 6 months ago by Yang

Modified:
8 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Port r7868 (constant masking) to x64. BUG=v8:1374 TEST=test-compiler/SplitConstantsInFullCompiler Committed: https://code.google.com/p/v8/source/detail?r=11932

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -9 lines)			Patch
M	src/ia32/full-codegen-ia32.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download
M	test/cctest/test-compiler.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

Please take a look. This CL is based on http://codereview.chromium.org/7005031/

8 years, 6 months ago (2012-06-26 12:14:11 UTC) #1

Erik Corry

LGTM The title is somewhat misleading. We are xoring the constants, not splitting them into ...

8 years, 6 months ago (2012-06-26 12:26:40 UTC) #2

Yang

I removed constant masking for function argument lengths since those values are not large enough ...

8 years, 6 months ago (2012-06-26 12:56:16 UTC) #3

LGTM