Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/ui/cocoa/history_menu_bridge.mm

Issue 10662041: mac: Remove nav.pdf in favor of IDR_DEFAULT_FAVICON. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/history_menu_bridge.h" 5 #include "chrome/browser/ui/cocoa/history_menu_bridge.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "base/sys_string_conversions.h" 12 #include "base/sys_string_conversions.h"
13 #include "chrome/app/chrome_command_ids.h" // IDC_HISTORY_MENU 13 #include "chrome/app/chrome_command_ids.h" // IDC_HISTORY_MENU
14 #import "chrome/browser/app_controller_mac.h" 14 #import "chrome/browser/app_controller_mac.h"
15 #include "chrome/browser/history/page_usage_data.h" 15 #include "chrome/browser/history/page_usage_data.h"
16 #include "chrome/browser/history/history_service_factory.h" 16 #include "chrome/browser/history/history_service_factory.h"
17 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/sessions/session_types.h" 18 #include "chrome/browser/sessions/session_types.h"
19 #include "chrome/browser/sessions/tab_restore_service_factory.h" 19 #include "chrome/browser/sessions/tab_restore_service_factory.h"
20 #import "chrome/browser/ui/cocoa/history_menu_cocoa_controller.h" 20 #import "chrome/browser/ui/cocoa/history_menu_cocoa_controller.h"
21 #include "chrome/common/chrome_notification_types.h" 21 #include "chrome/common/chrome_notification_types.h"
22 #include "chrome/common/url_constants.h" 22 #include "chrome/common/url_constants.h"
23 #include "content/public/browser/notification_registrar.h" 23 #include "content/public/browser/notification_registrar.h"
24 #include "content/public/browser/notification_source.h" 24 #include "content/public/browser/notification_source.h"
25 #include "grit/generated_resources.h" 25 #include "grit/generated_resources.h"
26 #include "grit/theme_resources.h" 26 #include "grit/theme_resources.h"
27 #include "grit/theme_resources_standard.h" 27 #include "grit/theme_resources_standard.h"
28 #include "grit/ui_resources.h" 28 #include "grit/ui_resources_standard.h"
29 #include "skia/ext/skia_utils_mac.h" 29 #include "skia/ext/skia_utils_mac.h"
30 #include "third_party/skia/include/core/SkBitmap.h" 30 #include "third_party/skia/include/core/SkBitmap.h"
31 #include "ui/base/l10n/l10n_util.h" 31 #include "ui/base/l10n/l10n_util.h"
32 #include "ui/base/resource/resource_bundle.h" 32 #include "ui/base/resource/resource_bundle.h"
33 #include "ui/gfx/codec/png_codec.h" 33 #include "ui/gfx/codec/png_codec.h"
34 #include "ui/gfx/image/image.h" 34 #include "ui/gfx/image/image.h"
35 #include "ui/gfx/mac/nsimage_cache.h" 35 #include "ui/gfx/mac/nsimage_cache.h"
36 36
37 namespace { 37 namespace {
38 38
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 } 92 }
93 93
94 tab_restore_service_ = TabRestoreServiceFactory::GetForProfile(profile_); 94 tab_restore_service_ = TabRestoreServiceFactory::GetForProfile(profile_);
95 if (tab_restore_service_) { 95 if (tab_restore_service_) {
96 tab_restore_service_->AddObserver(this); 96 tab_restore_service_->AddObserver(this);
97 tab_restore_service_->LoadTabsFromLastSession(); 97 tab_restore_service_->LoadTabsFromLastSession();
98 } 98 }
99 } 99 }
100 100
101 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 101 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
102 default_favicon_.reset([gfx::GetCachedImageWithName(@"nav.pdf") retain]); 102 default_favicon_.reset([rb.GetNativeImageNamed(IDR_DEFAULT_FAVICON) retain]);
103 103
104 // Set the static icons in the menu. 104 // Set the static icons in the menu.
105 NSMenuItem* item = [HistoryMenu() itemWithTag:IDC_SHOW_HISTORY]; 105 NSMenuItem* item = [HistoryMenu() itemWithTag:IDC_SHOW_HISTORY];
106 [item setImage:rb.GetNativeImageNamed(IDR_HISTORY_FAVICON)]; 106 [item setImage:rb.GetNativeImageNamed(IDR_HISTORY_FAVICON)];
107 107
108 // The service is not ready for use yet, so become notified when it does. 108 // The service is not ready for use yet, so become notified when it does.
109 if (!history_service_) { 109 if (!history_service_) {
110 registrar_.Add( 110 registrar_.Add(
111 this, chrome::NOTIFICATION_HISTORY_LOADED, 111 this, chrome::NOTIFICATION_HISTORY_LOADED,
112 content::Source<Profile>(profile_)); 112 content::Source<Profile>(profile_));
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 void HistoryMenuBridge::CancelFaviconRequest(HistoryItem* item) { 488 void HistoryMenuBridge::CancelFaviconRequest(HistoryItem* item) {
489 DCHECK(item); 489 DCHECK(item);
490 if (item->icon_requested) { 490 if (item->icon_requested) {
491 FaviconService* service = 491 FaviconService* service =
492 profile_->GetFaviconService(Profile::EXPLICIT_ACCESS); 492 profile_->GetFaviconService(Profile::EXPLICIT_ACCESS);
493 service->CancelRequest(item->icon_handle); 493 service->CancelRequest(item->icon_handle);
494 item->icon_requested = false; 494 item->icon_requested = false;
495 item->icon_handle = NULL; 495 item->icon_handle = NULL;
496 } 496 }
497 } 497 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698