Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10662041: mac: Remove nav.pdf in favor of IDR_DEFAULT_FAVICON. (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, jennb, jochen+watch-content_chromium.org, yoshiki+watch_chromium.org, jam, Dmitry Titov, jianli, joi+watch-content_chromium.org, darin-cc_chromium.org, dcheng, oshima+watch_chromium.org
Visibility:
Public.

Description

mac: Remove nav.pdf in favor of IDR_DEFAULT_FAVICON. Copy default_100/default_large_favicon.png to default_200/default_favicon.png BUG=111101 TEST=Favicons on bookmark bar, in history menu, etc still look good in both lodpi and hidpi. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144313

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 4

Patch Set 7 : contentclient #

Patch Set 8 : rebase #

Patch Set 9 : . #

Patch Set 10 : deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -28 lines) Patch
M chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm View 1 2 3 4 5 6 7 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util.mm View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_content_client.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/DEPS View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_client.h View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/common/content_client.cc View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
A + ui/resources/default_200_percent/default_favicon.png View 1 Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M ui/resources/ui_resources_standard.grd View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/button_drag_utils.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
Amazing in how many files we used to use nav.pdf.
8 years, 6 months ago (2012-06-26 06:59:42 UTC) #1
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/10662041/diff/7024/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm File chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm (left): https://chromiumcodereview.appspot.com/10662041/diff/7024/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm#oldcode352 chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm:352: favicon = gfx::GetCachedImageWithName(@"nav.pdf"); How soon will it be before ...
8 years, 6 months ago (2012-06-26 14:28:27 UTC) #2
Nico
I talked with jam, he recommended just adding a function for GetNativeImageNamed() to content client. ...
8 years, 6 months ago (2012-06-26 21:45:44 UTC) #3
Avi (use Gerrit)
lgtm
8 years, 6 months ago (2012-06-26 21:50:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10662041/20001
8 years, 6 months ago (2012-06-26 22:15:19 UTC) #5
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 6 months ago (2012-06-26 22:15:25 UTC) #6
Nico
8 years, 6 months ago (2012-06-26 23:06:00 UTC) #7 
+sky for OWNERS

Powered by Google App Engine
This is Rietveld 408576698