Issue 10662037: basic nc paint, moving, resizing for views_examples_exe on win

Issue 10662037: basic nc paint, moving, resizing for views_examples_exe on win (Closed)

Created:
8 years, 5 months ago by scottmg

Modified:
8 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

basic nc paint, moving, resizing for views_examples_exe on win non-aero Pull over some code from native_widget_win to get aura drawing a bit better on Windows. There's still lots of things not working, but the sizing and painting work better now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147255

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tidy #

Patch Set 4 : avoid adjustrect #

Patch Set 5 : remove not-yet-working code #

Patch Set 6 : remove more inprogress code #

Patch Set 7 : remove some more #

Total comments: 2

Patch Set 8 : GetHwnd->hwnd #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+349 lines, -133 lines)			Patch
M	ui/gfx/gdi_util.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	ui/gfx/gdi_util.cc	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	ui/gfx/path_aura.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.cc	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/widget/widget_message_filter.h	View	1 2 3 4 5 6 7	1 chunk	+8 lines, -1 line	0 comments	Download
M	ui/views/widget/widget_message_filter.cc	View	1 2 3 4 5 6 7	1 chunk	+310 lines, -131 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Cool! LGTM. https://chromiumcodereview.appspot.com/10662037/diff/6002/ui/views/widget/widget_message_filter.h File ui/views/widget/widget_message_filter.h (right): https://chromiumcodereview.appspot.com/10662037/diff/6002/ui/views/widget/widget_message_filter.h#newcode50 ui/views/widget/widget_message_filter.h:50: HWND GetHwnd() const; HWND hwnd() const;

8 years, 5 months ago (2012-06-29 18:25:54 UTC) #2

scottmg

https://chromiumcodereview.appspot.com/10662037/diff/6002/ui/views/widget/widget_message_filter.h File ui/views/widget/widget_message_filter.h (right): https://chromiumcodereview.appspot.com/10662037/diff/6002/ui/views/widget/widget_message_filter.h#newcode50 ui/views/widget/widget_message_filter.h:50: HWND GetHwnd() const; On 2012/06/29 18:25:54, Ben Goodger (Google) ...

8 years, 5 months ago (2012-06-29 18:31:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10662037/7007

8 years, 5 months ago (2012-06-29 18:31:16 UTC) #4

commit-bot: I haz the power

Try job failure for 10662037-7007 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...

8 years, 5 months ago (2012-06-29 19:14:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10662037/7007

8 years, 5 months ago (2012-07-18 15:44:03 UTC) #6

Change committed as 147255

Expand Messages | Collapse Messages