[Sync] Put everything in sync/api into csync namespace

[Sync] Put everything in sync/api into csync namespace

BUG=128060
TEST=
TBR=pkasting@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144385

[akalin, 2012-06-26 00:10:18]

+tim for sync/ and chrome/browser/sync
+asargent for chrome/browser/extensions
+mnissler for chrome/browser/prefs
+pkasting for chrome/browser/search_engines
+isherman for chrome/browser/webdata

[Ilya Sherman, 2012-06-26 01:06:03]

LGTM

Why is the namespace named csync rather than just sync?

[Mattias Nissler (ping if slow), 2012-06-26 09:09:34]

chrome/browser/prefs LGTM, but I'm with Ilya when it comes to the csync name:
Why is it "csync" instead of "sync", and what does the c stand for?

[akalin, 2012-06-26 16:59:10]

On 2012/06/26 09:09:34, Mattias Nissler wrote:
> chrome/browser/prefs LGTM, but I'm with Ilya when it comes to the csync name:
> Why is it "csync" instead of "sync", and what does the c stand for?

there's already a 'sync' function from unistd.h. :( csync = "cloud sync".

[asargent_no_longer_on_chrome, 2012-06-26 18:08:17]

extensions files LGTM

Looks like you accidentally included a double space in some search and replace
string - I noted it everywhere I saw it but might have missed some so you might
want to use the power of sed or regexes in your favorite editor or something to
make sure you fix them all.

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_service.h (right):

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_service.h:438: extensions::ExtensionSyncData
 GetExtensionSyncData(
nit: double space before GetExtensionSyncData

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_service.h:446: // Gets the ExtensionSyncData
 for all extensions.
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_service.h:452: // Applies the change
specified passed in by either ExtensionSyncData  or
nit: double space before "or" at end of line

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_sync_bundle.cc (right):

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_sync_bundle.cc:32: ExtensionSyncData 
extension_sync_data(*i);
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_sync_bundle.cc:47:
extensions::ExtensionSyncData  sync_data =
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_sync_bundle.cc:80: ExtensionSyncData 
extension_sync_data =
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_sync_bundle.cc:91: ExtensionSyncData 
extension_sync_data) {
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_sync_data.h (right):

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_sync_data.h:29: class ExtensionSyncData  {
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_sync_data.h:44: // Convert an
ExtensionSyncData  back out to a sync structure.
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_sync_data_unittest.cc (right):

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_sync_data_unittest.cc:74:
extensions::ExtensionSyncData  extension_sync_data(sync_data);
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
File chrome/browser/extensions/settings/settings_backend.cc (right):

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
chrome/browser/extensions/settings/settings_backend.cc:195: SettingSyncData 
data(*it);
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
chrome/browser/extensions/settings/settings_backend.cc:250: SettingSyncData 
data(*it);
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
File chrome/browser/extensions/settings/settings_sync_unittest.cc (right):

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
chrome/browser/extensions/settings/settings_sync_unittest.cc:84: // being
converted to the more useful SettingSyncData  via changes().
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
chrome/browser/extensions/settings/settings_sync_unittest.cc:120:
SettingSyncData  GetOnlyChange(
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
chrome/browser/extensions/settings/settings_sync_unittest.cc:252:
SettingSyncData  sync_data(*it);
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
chrome/browser/extensions/settings/settings_sync_unittest.cc:371:
SettingSyncData  change = sync_processor_->GetOnlyChange("s1", "foo");
nit: double space

http://codereview.chromium.org/10662035/diff/1/chrome/browser/extensions/sett...
chrome/browser/extensions/settings/settings_sync_unittest.cc:529:
SettingSyncData  change = sync_processor_->GetOnlyChange("s1", "bar");
nit: double space

[akalin, 2012-06-26 20:28:28]

Used sed to clean up the double spaces

tim, pkasting, ping!

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_service.h (right):

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_service.h:438: extensions::ExtensionSyncData
 GetExtensionSyncData(
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space before GetExtensionSyncData

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_service.h:446: // Gets the ExtensionSyncData
 for all extensions.
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_service.h:452: // Applies the change
specified passed in by either ExtensionSyncData  or
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space before "or" at end of line

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_sync_bundle.cc (right):

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sync_bundle.cc:32: ExtensionSyncData 
extension_sync_data(*i);
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sync_bundle.cc:47:
extensions::ExtensionSyncData  sync_data =
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sync_bundle.cc:80: ExtensionSyncData 
extension_sync_data =
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sync_bundle.cc:91: ExtensionSyncData 
extension_sync_data) {
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_sync_data.h (right):

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sync_data.h:29: class ExtensionSyncData  {
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sync_data.h:44: // Convert an
ExtensionSyncData  back out to a sync structure.
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_sync_data_unittest.cc (right):

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sync_data_unittest.cc:74:
extensions::ExtensionSyncData  extension_sync_data(sync_data);
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/settings/settings_backend.cc (right):

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/settings/settings_backend.cc:195: SettingSyncData 
data(*it);
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/settings/settings_backend.cc:250: SettingSyncData 
data(*it);
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/settings/settings_sync_unittest.cc (right):

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/settings/settings_sync_unittest.cc:84: // being
converted to the more useful SettingSyncData  via changes().
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/settings/settings_sync_unittest.cc:120:
SettingSyncData  GetOnlyChange(
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/settings/settings_sync_unittest.cc:252:
SettingSyncData  sync_data(*it);
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/settings/settings_sync_unittest.cc:371:
SettingSyncData  change = sync_processor_->GetOnlyChange("s1", "foo");
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

https://chromiumcodereview.appspot.com/10662035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/settings/settings_sync_unittest.cc:529:
SettingSyncData  change = sync_processor_->GetOnlyChange("s1", "bar");
On 2012/06/26 18:08:17, Antony Sargent wrote:
> nit: double space

Done.

[akalin, 2012-06-27 00:32:00]

-timsteele, +rlaroque

[rlarocque, 2012-06-27 01:32:52]

LGTM with some very minor nits.

http://codereview.chromium.org/10662035/diff/11001/chrome/browser/sync/glue/g...
File chrome/browser/sync/glue/generic_change_processor.h (right):

http://codereview.chromium.org/10662035/diff/11001/chrome/browser/sync/glue/g...
chrome/browser/sync/glue/generic_change_processor.h:24: }  // namespace
}  // namespace csync

http://codereview.chromium.org/10662035/diff/11001/sync/api/sync_error.cc
File sync/api/sync_error.cc (right):

http://codereview.chromium.org/10662035/diff/11001/sync/api/sync_error.cc#new...
sync/api/sync_error.cc:113: 
nit: trailing whitespace

http://codereview.chromium.org/10662035/diff/11001/sync/api/sync_error_factor...
File sync/api/sync_error_factory.cc (right):

http://codereview.chromium.org/10662035/diff/11001/sync/api/sync_error_factor...
sync/api/sync_error_factory.cc:16: 
nit: trailing whitespace

[akalin, 2012-06-27 01:40:08]

TBRing pkasting since the searchengine changes are pretty minor

http://codereview.chromium.org/10662035/diff/11001/chrome/browser/sync/glue/g...
File chrome/browser/sync/glue/generic_change_processor.h (right):

http://codereview.chromium.org/10662035/diff/11001/chrome/browser/sync/glue/g...
chrome/browser/sync/glue/generic_change_processor.h:24: }  // namespace
On 2012/06/27 01:32:53, rlarocque wrote:
> }  // namespace csync

Done.

http://codereview.chromium.org/10662035/diff/11001/sync/api/sync_error.cc
File sync/api/sync_error.cc (right):

http://codereview.chromium.org/10662035/diff/11001/sync/api/sync_error.cc#new...
sync/api/sync_error.cc:113: 
On 2012/06/27 01:32:53, rlarocque wrote:
> nit: trailing whitespace

Done.

http://codereview.chromium.org/10662035/diff/11001/sync/api/sync_error_factor...
File sync/api/sync_error_factory.cc (right):

http://codereview.chromium.org/10662035/diff/11001/sync/api/sync_error_factor...
sync/api/sync_error_factory.cc:16: 
On 2012/06/27 01:32:53, rlarocque wrote:
> nit: trailing whitespace

Done.

[commit-bot: I haz the power, 2012-06-27 01:40:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10662035/23005

[commit-bot: I haz the power, 2012-06-27 03:15:55]

Change committed as 144385