webkit/media/webmediaplayer_impl.cc - Issue 10662030: WebMediaPlayerImpl needs to own the audio source provider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/media/webmediaplayer_impl.cc

Issue 10662030: WebMediaPlayerImpl needs to own the audio source provider. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Update from review 2 Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/media/webmediaplayer_impl.cc

diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc

index 41bcf11d39f5687331feea492ccabf7bf26d80cc..efb88b50fec1b9b1f614fb3a100868bb80b692f9 100644

--- a/webkit/media/webmediaplayer_impl.cc

+++ b/webkit/media/webmediaplayer_impl.cc

@@ -105,6 +105,7 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(

base::WeakPtr<WebMediaPlayerDelegate> delegate,

media::FilterCollection* collection,

WebKit::WebAudioSourceProvider* audio_source_provider,

+ media::AudioRendererSink* audio_renderer_sink,

media::MessageLoopFactory* message_loop_factory,

MediaStreamClient* media_stream_client,

media::MediaLog* media_log)

@@ -128,6 +129,7 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(

accelerated_compositing_reported_(false),

incremented_externally_allocated_memory_(false),

audio_source_provider_(audio_source_provider),

+ audio_renderer_sink_(audio_renderer_sink),

is_local_source_(false),

decryptor_(proxy_.get()) {

media_log_->AddEvent(

« no previous file with comments | « webkit/media/webmediaplayer_impl.h ('k') | webkit/support/webkit_support.cc » ('j') | no next file with comments »