Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: webkit/media/webmediaplayer_impl.cc

Issue 10662030: WebMediaPlayerImpl needs to own the audio source provider. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/webmediaplayer_impl.cc
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index 5707a7b9ac76dfb1a93dbb8c71621e93665a1145..fb6738f712d059e8c6e625faa0414b34f063c4ed 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -107,6 +107,7 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
base::WeakPtr<WebMediaPlayerDelegate> delegate,
media::FilterCollection* collection,
WebKit::WebAudioSourceProvider* audio_source_provider,
+ media::AudioRendererSink* audio_renderer_sink,
media::MessageLoopFactory* message_loop_factory,
MediaStreamClient* media_stream_client,
media::MediaLog* media_log)
@@ -130,6 +131,7 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
accelerated_compositing_reported_(false),
incremented_externally_allocated_memory_(false),
audio_source_provider_(audio_source_provider),
+ audio_renderer_sink_(audio_renderer_sink),
is_local_source_(false) {
media_log_->AddEvent(
scherkus (not reviewing) 2012/07/09 23:13:23 can you DCHECK_EQ() that the two pointers are equa
Raymond Toy 2012/07/10 02:51:39 No, I can't do that because they're pointers deriv
scherkus (not reviewing) 2012/07/10 17:13:51 Right -- that makes sense :\
media_log_->CreateEvent(media::MediaLogEvent::WEBMEDIAPLAYER_CREATED));

Powered by Google App Engine
This is Rietveld 408576698