Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: remoting/webapp/host_session.js

Issue 10661058: Move responsibility for l10n parameters to the caller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed parameter name. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/host_session.js
diff --git a/remoting/webapp/host_session.js b/remoting/webapp/host_session.js
index fb064e563da632a77ee5851dbf85435564ef9ee0..d1f9a1460af83e2ea88662c65d0b5dfc6eb5d01b 100644
--- a/remoting/webapp/host_session.js
+++ b/remoting/webapp/host_session.js
@@ -72,16 +72,7 @@ remoting.HostSession.prototype.createPluginAndConnect =
this.plugin.onNatTraversalPolicyChanged = onNatTraversalPolicyChanged;
this.plugin.onStateChanged = onStateChanged;
this.plugin.logDebugInfo = logDebugInfo;
- this.plugin.localize(
- /** @param {string} id */
- function(id) {
- // Plugin takes care of string substitution, so we just keep
- // $ placeholders.
- // TODO(sergeyu): Refactor plugin location so that it
- // doesn't need to do any substitutions. crbug.com/132370 .
- return chrome.i18n.getMessage(id, ["$1", "$2", "$3"]);
- }
- );
+ this.plugin.localize(chrome.i18n.getMessage);
this.plugin.connect(email, 'oauth2:' + accessToken);
};
« remoting/host/plugin/host_script_object.cc ('K') | « remoting/host/plugin/host_script_object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698