Issue 10661030: Enable Pointer Lock by default, change about:flags option to multi-select.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10661030: Enable Pointer Lock by default, change about:flags option to multi-select. (Closed)

Created:
8 years, 6 months ago by scheib

Modified:
8 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable Pointer Lock by default, change about:flags option to multi-select. BUG=72754 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143931

Patch Set 1 #

Total comments: 1

Patch Set 2 : whitespace #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/about_flags.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

8 years, 6 months ago (2012-06-25 16:11:08 UTC) #2

lgtm

http://codereview.chromium.org/10661030/diff/1/content/public/common/content_...
File content/public/common/content_switches.cc (right):

http://codereview.chromium.org/10661030/diff/1/content/public/common/content_...
content/public/common/content_switches.cc:168: const char kDisablePointerLock[] 
           = "disable-pointer-lock";
nit: spacing looks off by 1?

Expand Messages | Collapse Messages