Ensure interfaces are loaded.

Ensure interfaces are loaded.

[Lasse Reichstein Nielsen, 2012-08-07 09:02:16]

LGTM

https://chromiumcodereview.appspot.com/10661029/diff/2002/dart/lib/compiler/i...
File dart/lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/10661029/diff/2002/dart/lib/compiler/i...
dart/lib/compiler/implementation/elements/elements.dart:888: bool
supertypesAreLoaded = false;
Should we consider some kind of "state" type with "uninitialized",
"initializing", "initialized" states? I'm think I'm seeing this pattern a little
too often!

https://chromiumcodereview.appspot.com/10661029/diff/2002/dart/lib/compiler/i...
dart/lib/compiler/implementation/elements/elements.dart:930:
compiler.resolver.resolveClass(this);
This looks like the job for a work queue. 
Can't we just queue this instead of doing it immediately?
It seems that all this boolean-fiddling is to handle recursive dependencies, so
we must be able to handle that sometimes the resolving isn't completely done
when we return. Why not just do that all the time then?
Then we just need one bit: isResolved, and the "being resolved" is represented
by being in the queue.

https://chromiumcodereview.appspot.com/10661029/diff/2002/dart/lib/compiler/i...
File dart/lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10661029/diff/2002/dart/lib/compiler/i...
dart/lib/compiler/implementation/resolver.dart:1953: // TODO(ahe): Can this
happen?
If it can, it should be fixed.

https://chromiumcodereview.appspot.com/10661029/diff/2002/dart/lib/compiler/i...
File dart/lib/compiler/implementation/typechecker.dart (right):

https://chromiumcodereview.appspot.com/10661029/diff/2002/dart/lib/compiler/i...
dart/lib/compiler/implementation/typechecker.dart:119: void
initializeFrom(FunctionType other) {
Why is this not a constructor?
I only see one use of it, and that's on a newly created FunctionType object.
I.e., I suggest:

FunctionType.from(FunctionType other, Element this.element) : returnType =
other.returnType, parameterTypes = other.parameterTypes;

[ahe, 2012-08-14 10:57:05]

Thank you, Lasse!

It turned out it was more tricky to get your state suggestion to work and I have
ended up landing this change as part of other CLs:
https://chromiumcodereview.appspot.com/10836235/ (out for review) and
https://chromiumcodereview.appspot.com/10855125/ (committed).

I'll close this CL.

Cheers,
Peter