Remove the linux-only CR_SOURCE_ROOT environment variable override of base::DIR_SOURCE_ROOT.

Remove the linux-only CR_SOURCE_ROOT environment variable override of base::DIR_SOURCE_ROOT.

The environment variable overidde was only implemented on linux and not on the
other OSes. So it was not coherent across platforms. I searched for usage and
didn't find anything compelling. If this change causes any breakage, simply
revert it. If is is needed, it should be made coherent between platforms.

Note that this trick is not compatible with test isolation, where test should
find their data file at deterministic relative location, hence the removal of
this override.

R=willchan@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144460

[M-A Ruel, 2012-06-26 20:16:15]

ping

[willchan no longer on Chromium, 2012-06-26 21:14:09]

My bad, at a conference. LGTM

On Tue, Jun 26, 2012 at 1:16 PM, <maruel@chromium.org> wrote:

> ping
>
>
http://chromiumcodereview.**appspot.com/10661019/<http://chromiumcodereview.a...
>

[commit-bot: I haz the power, 2012-06-27 00:30:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10661019/1

[commit-bot: I haz the power, 2012-06-27 01:05:48]

Try job failure for 10661019-1 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-06-27 13:15:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10661019/1

[commit-bot: I haz the power, 2012-06-27 15:04:16]

Change committed as 144460

[piman, 2012-07-02 20:28:52]

This makes me sad.
My output dir is 3 levels down instead of 2 (I bind-mount an output root from
another disk, below which I have an indirection fro the configuration linux vs
aura vs chrome os etc., below which I have Debug vs Release), and I was relying
on CR_SOURCE_ROOT to correctly execute unit tests. Now I don't have that hook
any more, is there an alternative?

[M-A Ruel, 2012-07-02 20:58:29]

On 2012/07/02 20:28:52, piman wrote:
> This makes me sad.
> My output dir is 3 levels down instead of 2 (I bind-mount an output root from
> another disk, below which I have an indirection fro the configuration linux vs
> aura vs chrome os etc., below which I have Debug vs Release), and I was
relying
> on CR_SOURCE_ROOT to correctly execute unit tests. Now I don't have that hook
> any more, is there an alternative?

There's no alternative AFAIK but I'm open to put it back. The main reason I
removed it was that I didn't know if this "feature" got any usage. Now at least
I know it's being used. But I prefer to first make it consistent across
platforms. I'll send a CL within the next few days.