Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10660030: Remove warning about instantiating an abstract class without implementing a member (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
index 4555fa21a0af048b88d824edeafb1ab6d5a1fb89..9ba0a35c87a22748ee2c29efb6b8263fc40343a8 100644
--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
@@ -1256,7 +1256,8 @@ public class TypeAnalyzer implements DartCompilationPhase {
ClassNodeElement element = node.getElement();
InterfaceType type = element.getType();
checkCyclicBounds(type.getArguments());
- List<Element> unimplementedMembers = findUnimplementedMembers(element);
+ // remember unimplemented members
+ findUnimplementedMembers(element);
setCurrentClass(type);
visit(node.getTypeParameters());
if (node.getSuperclass() != null) {
@@ -1267,21 +1268,8 @@ public class TypeAnalyzer implements DartCompilationPhase {
validateTypeNode(interfaceNode, false);
}
}
-
visit(node.getMembers());
checkInterfaceConstructors(element);
- // Report unimplemented members.
- if (!node.isAbstract()) {
- if (unimplementedMembers.size() > 0) {
- StringBuilder sb = getUnimplementedMembersMessage(element, unimplementedMembers);
- typeError(
- node.getName(),
- TypeErrorCode.ABSTRACT_CLASS_WITHOUT_ABSTRACT_MODIFIER,
- element.getName(),
- sb);
- }
- }
-
try {
checkClassDuplicateInterfaces(node, element, element.getAllSupertypes());
} catch (CyclicDeclarationException ignored) {

Powered by Google App Engine
This is Rietveld 408576698