Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 10660028: Issue 3789. Resolve library prefix for LibraryElement for field and function references. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
index bcd65d089c2bfd69714ee71a5865f965cb33756c..349f7b7b4437e684d32c9aa7f2ef914314e02b6a 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
@@ -1221,7 +1221,9 @@ public class Resolver {
// Library prefix, lookup the element in the referenced library.
Scope scope = ((LibraryPrefixElement) qualifier).getScope();
element = scope.findElement(scope.getLibrary(), x.getPropertyName());
- if (element == null) {
+ if (element != null) {
+ recordElement(x.getQualifier(), element.getEnclosingElement());
+ } else {
onError(x, ResolverErrorCode.CANNOT_BE_RESOLVED_LIBRARY,
x.getPropertyName(), qualifier.getName());
}
@@ -1325,6 +1327,7 @@ public class Resolver {
if (element == null) {
diagnoseErrorInMethodInvocation(x, library, null);
} else {
+ recordElement(x.getTarget(), element.getEnclosingElement());
name.setElement(element);
}
break;

Powered by Google App Engine
This is Rietveld 408576698