Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: lib/compiler/implementation/ssa/tracer.dart

Issue 10660026: Don't allow statement-nodes in expression contexts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix test for checked mode. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/tracer.dart
diff --git a/lib/compiler/implementation/ssa/tracer.dart b/lib/compiler/implementation/ssa/tracer.dart
index 8f543d4784576876550d0342287751c3ce97f2b3..de9fa3f0f47d96f837fa8edc3e19fca73322a8e6 100644
--- a/lib/compiler/implementation/ssa/tracer.dart
+++ b/lib/compiler/implementation/ssa/tracer.dart
@@ -243,12 +243,14 @@ class HInstructionStringifier implements HVisitor<String> {
String visitExit(HExit node) => "exit";
String visitFieldGet(HFieldGet node) {
- return 'get ${temporaryId(node.receiver)}';
+ String fieldName = node.element.name.slowToString();
+ return 'get ${temporaryId(node.receiver)}.$fieldName';
}
String visitFieldSet(HFieldSet node) {
String valueId = temporaryId(node.value);
- return 'set ${temporaryId(node.receiver)} to $valueId';
+ String fieldName = node.element.name.slowToString();
+ return 'set ${temporaryId(node.receiver)}.$fieldName to $valueId';
}
String visitLocalGet(HLocalGet node) => visitFieldGet(node);
@@ -478,7 +480,7 @@ class HInstructionStringifier implements HVisitor<String> {
envBuffer.add(" ${temporaryId(inputs[i])}");
}
}
- String on = node.isOn ? "on" : "off";
+ String on = node.isEnabled ? "enabled" : "disabled";
String id = temporaryId(node.guarded);
return "TypeGuard($on): $id is $type env: $envBuffer";
}

Powered by Google App Engine
This is Rietveld 408576698