Update manager fixes to handle update check failures.

Update manager fixes to handle update check failures.
Committed: https://code.google.com/p/dart/source/detail?r=9125

[devoncarew, 2012-06-25 22:51:51]

lgtm

http://codereview.chromium.org/10660016/diff/2001/editor/tools/plugins/com.go...
File
editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/internal/jobs/CheckForUpdatesJob.java
(right):

http://codereview.chromium.org/10660016/diff/2001/editor/tools/plugins/com.go...
editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/internal/jobs/CheckForUpdatesJob.java:59:
UpdateCore.logError("Unable to get latest revision: " +
e.getMessage());//$NON-NLS-1$
What about storing this error, and having the update manager pass it into
listeners to the update process? As is currently is, the updateFailed()
notification passes no arguments to receivers, and gives no indication as to why
the update failed.

[jwren, 2012-06-25 23:41:30]

On 2012/06/25 22:51:51, devoncarew wrote:
> lgtm
> 
>
http://codereview.chromium.org/10660016/diff/2001/editor/tools/plugins/com.go...
> File
>
editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/internal/jobs/CheckForUpdatesJob.java
> (right):
> 
>
http://codereview.chromium.org/10660016/diff/2001/editor/tools/plugins/com.go...
>
editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/internal/jobs/CheckForUpdatesJob.java:59:
> UpdateCore.logError("Unable to get latest revision: " +
> e.getMessage());//$NON-NLS-1$
> What about storing this error, and having the update manager pass it into
> listeners to the update process? As is currently is, the updateFailed()
> notification passes no arguments to receivers, and gives no indication as to
why
> the update failed.

LGTM

[pquitslund, 2012-06-26 18:10:22]

Thanks!

updateFailed() now passes an error message which is handed off to listeners.

https://chromiumcodereview.appspot.com/10660016/diff/2001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/internal/jobs/CheckForUpdatesJob.java
(right):

https://chromiumcodereview.appspot.com/10660016/diff/2001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/internal/jobs/CheckForUpdatesJob.java:59:
UpdateCore.logError("Unable to get latest revision: " +
e.getMessage());//$NON-NLS-1$
On 2012/06/25 22:51:51, devoncarew wrote:
> What about storing this error, and having the update manager pass it into
> listeners to the update process? As is currently is, the updateFailed()
> notification passes no arguments to receivers, and gives no indication as to
why
> the update failed.

Right.  As per our conversation, I've plumbed this through.