Fix flaky PPAPITest.FileIO_NotAllowMixedReadWrite, re-enable

Fix flaky PPAPITest.FileIO_NotAllowMixedReadWrite, re-enable

NotAllowMixedReadWrite starts a Write, then checks that various other calls aren't allowed at the same time. But each of these uses TestCompletionCallback::WaitForResult, which runs a nested message loop. So the Write can complete any time that happens, meaning the later calls won't always fail with PP_ERROR_INPROGRESS.

Also re-enable PPAPINaCl[GLibc|NewLib]Test.FileIO_NotAllowMixedReadWrite

BUG=134442
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144060

[viettrungluu, 2012-06-25 21:41:34]

http://codereview.chromium.org/10660010/diff/8001/ppapi/tests/test_file_io.cc
File ppapi/tests/test_file_io.cc (right):

http://codereview.chromium.org/10660010/diff/8001/ppapi/tests/test_file_io.cc...
ppapi/tests/test_file_io.cc:909: TestCompletionCallback
callback_3(instance_->pp_instance(), force_async_);
(Here and elsewhere:) I suppose you should |ASSERT_EQ(PP_OK_COMPLETIONPENDING,
rv_1);| or something.

http://codereview.chromium.org/10660010/diff/8001/ppapi/tests/test_file_io.cc...
ppapi/tests/test_file_io.cc:936: 
Nit: For consistency, you may as well remove this blank line.

[dmichael (off chromium), 2012-06-25 22:06:28]

http://codereview.chromium.org/10660010/diff/8001/ppapi/tests/test_file_io.cc
File ppapi/tests/test_file_io.cc (right):

http://codereview.chromium.org/10660010/diff/8001/ppapi/tests/test_file_io.cc...
ppapi/tests/test_file_io.cc:909: TestCompletionCallback
callback_3(instance_->pp_instance(), force_async_);
On 2012/06/25 21:41:34, viettrungluu wrote:
> (Here and elsewhere:) I suppose you should |ASSERT_EQ(PP_OK_COMPLETIONPENDING,
> rv_1);| or something.

Done.

http://codereview.chromium.org/10660010/diff/8001/ppapi/tests/test_file_io.cc...
ppapi/tests/test_file_io.cc:936: 
On 2012/06/25 21:41:34, viettrungluu wrote:
> Nit: For consistency, you may as well remove this blank line.

Done.

[viettrungluu, 2012-06-25 22:18:48]

lgtm

[commit-bot: I haz the power, 2012-06-25 22:41:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10660010/14001

[commit-bot: I haz the power, 2012-06-25 23:52:45]

Change committed as 144060